Add tags to CreateInstanceRequest #397
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cgillum
reviewed
Mar 19, 2025
cgillum
reviewed
Mar 19, 2025
cgillum
reviewed
Mar 19, 2025
cgillum
reviewed
Mar 20, 2025
jviau
previously requested changes
Mar 20, 2025
Member
jviau
left a comment
jviau
left a comment
There was a problem hiding this comment.
@torosent I think you have something with your git config causing newline changes in many files. Might be this? https://docs.github.com/en/get-started/git-basics/configuring-git-to-handle-line-endings
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
cgillum
requested changes
Mar 22, 2025
cgillum
reviewed
Mar 22, 2025
Member
cgillum
left a comment
cgillum
left a comment
There was a problem hiding this comment.
Code changes look good. A few more things to clean up before we merge.
Also, can you please add an entry for this PR to the CHANGELOG.md file?
cgillum
approved these changes
Mar 24, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.